Skip to content

fix(schematics): check polyfill in default project #6017 #6106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 11, 2019
Merged

fix(schematics): check polyfill in default project #6017 #6106

merged 8 commits into from
Nov 11, 2019

Conversation

@Lipata
Copy link
Member

@Lipata Lipata commented Nov 1, 2019 •
edited
Loading

Closes #6017

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@Lipata Lipata added ❌ status: awaiting-test PRs awaiting manual verification version: 9.0.x labels Nov 1, 2019
@Lipata Lipata requested a review from damyanpetev November 1, 2019 10:12
@jackofdiamond5 jackofdiamond5 added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Nov 1, 2019
@Lipata Lipata force-pushed the nalipiev/polyfill branch from 47c1079 to 67af0fb Compare November 4, 2019 09:31
@jackofdiamond5 jackofdiamond5 added ✅ status: verified Applies to PRs that have passed manual verification 🛠️ status: in-development Issues and PRs with active development on them and removed 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification labels Nov 5, 2019
@Lipata
Copy link
Member Author

Lipata commented Nov 7, 2019

You need to have this fix in the CLI.

@Lipata Lipata added ❌ status: awaiting-test PRs awaiting manual verification and removed 🛠️ status: in-development Issues and PRs with active development on them labels Nov 7, 2019
@jackofdiamond5 jackofdiamond5 added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Nov 11, 2019
@damyanpetev damyanpetev added the squash-merge Merge PR with "Squash and Merge" option label Nov 11, 2019
@Lipata Lipata merged commit 03edc2d into master Nov 11, 2019
@Lipata Lipata deleted the nalipiev/polyfill branch November 11, 2019 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@damyanpetev damyanpetev damyanpetev approved these changes

Assignees

@jackofdiamond5 jackofdiamond5

Labels

squash-merge Merge PR with "Squash and Merge" option version: 9.0.x ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ng-add schematic fails to update polyfills in non-default workspaces

5 participants

@Lipata @damyanpetev @jackofdiamond5 @kdinev