Skip to content

Fix error when delete child column from a column group #6161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 13, 2019
Merged

Fix error when delete child column from a column group #6161

merged 2 commits into from
Nov 13, 2019

Conversation

@nrobakova
Copy link
Contributor

@nrobakova nrobakova commented Nov 12, 2019

Closes #6134

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@nrobakova nrobakova requested a review from ddincheva November 12, 2019 07:57
@nrobakova nrobakova assigned ddincheva and hanastasov and unassigned ddincheva Nov 12, 2019
@hanastasov hanastasov added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Nov 13, 2019
@hanastasov hanastasov self-requested a review November 13, 2019 07:13
@rkaraivanov rkaraivanov merged commit e91e1f5 into 8.1.x Nov 13, 2019
@rkaraivanov rkaraivanov deleted the nrobakova/fix-issue-6134-81 branch November 13, 2019 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hanastasov hanastasov hanastasov approved these changes

@ddincheva ddincheva Awaiting requested review from ddincheva

Assignees

@hanastasov hanastasov

Labels

grid: general grid: multi-column-headers version: 8.1.x ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@nrobakova @hanastasov @rkaraivanov @ddincheva @Lipata