Skip to content

Slider ticks #6169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 74 commits into from
Nov 27, 2019
Merged

Slider ticks #6169

merged 74 commits into from
Nov 27, 2019

Conversation

@Aleksandyr
Copy link
Contributor

@Aleksandyr Aleksandyr commented Nov 13, 2019 •
edited
Loading

Closes #4594

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

Aleksandyr and others added 27 commits October 24, 2019 11:22
@Aleksandyr
feat(slider): poc ticks implementation
c6a17dc 
Closes #4594
@Aleksandyr
feat(slider): merge ticks feat with master
20fdb80 
Closes #4594
@Aleksandyr
feat(slider): set ticks and labels dimensions and indentions
e7dafce 
Closes #4594
@Aleksandyr
Merge branch 'master' of https://github.com/IgniteUI/igniteui-angular …
27786f6 
…into slider-ticks-master
@Aleksandyr
feat(slider): ticks feat as a separate component
5d42727 
Closes #4594
@Aleksandyr
feat(slider): finish label orientations
4b4887b 
Closes #4594
@Aleksandyr
feat(slider): integrate tick labels with labels feat
ac86fbe 
Closes #4594
@Aleksandyr
Merge branch 'master' of https://github.com/IgniteUI/igniteui-angular …
866604a 
…into slider-ticks-master
@Aleksandyr
feat(slider): show/hide secondary/primary tick labels
7fe44cb 
Closes #4594
@Aleksandyr
feat(slider): top|bottom|mirror ticks orientation
e3336a4 
Closes #4594
@Aleksandyr
fix(slider): top ticks integration with labels feat
6723a12 
Closes #4594
@Aleksandyr
feat(slider): allow tick labels custom template
cbd80c2 
Closes #4594
@Aleksandyr
feat(slider): drop svg and change template structure
a6f7af9 
Closes #4594
@Aleksandyr
Merge branch 'master' of https://github.com/IgniteUI/igniteui-angular …
9abb681 
…into slider-ticks-drop-svg-master
@Aleksandyr
fix(slider): remove resizeObserver
3f7a50a 
Closes #4594
fix(slider): Adding styles for slider ticks
a0aa55b 
Signed-off-by: MPopov <desig9stein@gmail.com>
Merge remote-tracking branch 'IGX/slider-ticks-drop-svg-master' into …
97ff935 
…slider-ticks-drop-svg-master
@Aleksandyr
feat(slider): expose classes for label hide/show and orientation
a1c68ca 
Closes #4594
@Aleksandyr
fix(slider): expose tick labels orientation properly
a4507d8 
Closes #4594
@Aleksandyr
Merge branch 'master' of https://github.com/IgniteUI/igniteui-angular …
75f1411 
…into slider-ticks-drop-svg-master
@Aleksandyr
Merge branch 'master' of https://github.com/IgniteUI/igniteui-angular …
6383966 
…into slider-ticks-drop-svg-master
feat(slider): Adding styling to ticks and labels of the slider component
e9e2b62 
1. Fix ie 11 positioning of the horizontal labels
2. Fix ie 11 positioning of the Thumbs
3. Fix miror view of the labesl on top
4. Fix wrong position of the thumb dot
5. Fix tick/label spacing
6. Adding colors for the theme

Signed-off-by: MPopov <desig9stein@gmail.com>
feat(slider): Fix the template to work as expected in chrome and add …
fc18430 
…styles fo hiding the labels

Signed-off-by: MPopov <desig9stein@gmail.com>
feat(slider): move the transition on the correct selector to work bot…
96bfb4b 
…h ways

Signed-off-by: MPopov <desig9stein@gmail.com>
@Aleksandyr
Merge branch 'slider-ticks-drop-svg-master' of https://github.com/Ign…
b5f0f10 
…iteUI/igniteui-angular into slider-ticks-drop-svg-master
@Aleksandyr
fix(slider): remove default lebal horizontal class
bdbe25f 
Closes #4594
@Aleksandyr
fix(slider): remove all comented code
756437c 
Closes #4594
@Aleksandyr Aleksandyr added the 🛠️ status: in-development Issues and PRs with active development on them label Nov 13, 2019
@Aleksandyr Aleksandyr added ❌ status: awaiting-test PRs awaiting manual verification and removed 🛠️ status: in-development Issues and PRs with active development on them labels Nov 22, 2019
@ddincheva ddincheva self-assigned this Nov 22, 2019
@zdrawku zdrawku added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Nov 27, 2019
@ddincheva ddincheva added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Nov 27, 2019
@zdrawku zdrawku merged commit a05bf6a into master Nov 27, 2019
@zdrawku zdrawku deleted the slider-ticks-drop-svg-master branch November 27, 2019 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zdrawku zdrawku zdrawku approved these changes

@ddincheva ddincheva Awaiting requested review from ddincheva

@rkaraivanov rkaraivanov Awaiting requested review from rkaraivanov

Assignees

@Aleksandyr Aleksandyr

@desig9stein desig9stein

@ddincheva ddincheva

Labels

slider 🧪 ci: tests version: 9.0.x ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add tics to <igx-slider> control

8 participants

@Aleksandyr @zdrawku @kdinev @desig9stein @ddincheva @rkaraivanov @nrobakova