Skip to content

Add carousel navigation buttons template #6179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Nov 20, 2019
Merged

Add carousel navigation buttons template #6179

merged 9 commits into from
Nov 20, 2019

Conversation

@nrobakova
Copy link
Contributor

@nrobakova nrobakova commented Nov 19, 2019

Closes #6141

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@nrobakova nrobakova self-assigned this Nov 19, 2019
@nrobakova nrobakova assigned HristoP96 and unassigned nrobakova Nov 19, 2019
@nrobakova nrobakova requested a review from hanastasov November 19, 2019 09:22
hanastasov
hanastasov previously approved these changes Nov 19, 2019
View reviewed changes
@HristoP96 HristoP96 added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Nov 19, 2019
hanastasov
hanastasov previously approved these changes Nov 19, 2019
View reviewed changes
simeonoff
simeonoff requested changes Nov 19, 2019
View reviewed changes
Copy link
Collaborator

@simeonoff simeonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work overall, please see my comments.

simeonoff
simeonoff approved these changes Nov 19, 2019
View reviewed changes
simeonoff
simeonoff requested changes Nov 19, 2019
View reviewed changes
Copy link
Collaborator

@simeonoff simeonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check my comments.

@HristoP96 HristoP96 added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Nov 20, 2019
@hanastasov hanastasov self-requested a review November 20, 2019 11:38
@Lipata Lipata merged commit fc33efb into master Nov 20, 2019
@Lipata Lipata deleted the nrobakova/carousel-addNavigationTemplates branch November 20, 2019 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simeonoff simeonoff simeonoff approved these changes

@hanastasov hanastasov hanastasov approved these changes

+1 more reviewer

@HristoP96 HristoP96 HristoP96 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@HristoP96 HristoP96

Labels

🎠 carousel version: 9.0.x ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Navigation buttons template implementation

6 participants

@nrobakova @simeonoff @hanastasov @HristoP96 @Lipata