Skip to content

Remove check for wheel listener from block scroll strategy #6256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 3, 2019
Merged

Remove check for wheel listener from block scroll strategy #6256

merged 5 commits into from
Dec 3, 2019

Conversation

@wnvko
Copy link
Contributor

@wnvko wnvko commented Dec 2, 2019 •
edited
Loading

For some reason there was wheel event listener in BlockScrollStrategy. As we have scroll handler I do not think we need the wheel one.

However we need to test this thoroughly

Closes #6226

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@wnvko wnvko added 🛠️ status: in-development Issues and PRs with active development on them overlay version: 9.0.x labels Dec 2, 2019
@wnvko wnvko marked this pull request as ready for review December 2, 2019 13:55
@wnvko wnvko added ❌ status: awaiting-test PRs awaiting manual verification and removed 🛠️ status: in-development Issues and PRs with active development on them labels Dec 2, 2019
@PlamenaMiteva PlamenaMiteva added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Dec 3, 2019
@Lipata Lipata merged commit 8c91151 into master Dec 3, 2019
@Lipata Lipata deleted the mvenkov/remove-onwheel-listener-from-block-scroll-strategy branch December 3, 2019 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@damyanpetev damyanpetev damyanpetev approved these changes

@ViktorSlavov ViktorSlavov Awaiting requested review from ViktorSlavov

Assignees

@PlamenaMiteva PlamenaMiteva

Labels

overlay version: 9.0.x ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Overlay] Block scroll strategy preventDefault error

5 participants

@wnvko @damyanpetev @Lipata @PlamenaMiteva