Skip to content

Conversation

@mddragnev
Copy link
Member

…ength #5126

Closes #5126

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@ChronosSF ChronosSF added 💥 status: in-test PRs currently being tested 🛠️ status: in-development Issues and PRs with active development on them and removed ❌ status: awaiting-test PRs awaiting manual verification labels Jan 13, 2020
@ChronosSF ChronosSF removed the 💥 status: in-test PRs currently being tested label Jan 13, 2020
@ChronosSF
Copy link
Member

ChronosSF commented Jan 13, 2020

The issue still reproduces if navigating up instead of down. Check if you can apply code similar to the one that prevents the bug from occuring when navigating between children of the same level:

private focusNextChild(elem, visibleColumnIndex, grid) {
...
        // Update column index since the next child can have in general less columns than visibleColumnIndex value.
        const lastCellIndex = childGrid.unpinnedColumns[childGrid.unpinnedColumns.length - 1].visibleIndex;
        visibleColumnIndex = Math.min(lastCellIndex, visibleColumnIndex);
...
}

@mddragnev mddragnev added ❌ status: awaiting-test PRs awaiting manual verification and removed 🛠️ status: in-development Issues and PRs with active development on them labels Jan 14, 2020
@ChronosSF ChronosSF added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Jan 15, 2020
@ChronosSF ChronosSF added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Jan 17, 2020
@ChronosSF ChronosSF merged commit 1c06418 into master Jan 20, 2020
@ChronosSF ChronosSF deleted the mdragnev/fix-5126-master branch January 20, 2020 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Keyboard navigation is not working when going from child to parent where parent has less columns.

4 participants