Skip to content

fix(igxHGrid): Make sure visibleColumnIndex is not greater than columns l… #6444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChronosSF merged 11 commits into from
Jan 20, 2020
Merged

fix(igxHGrid): Make sure visibleColumnIndex is not greater than columns l… #6444

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
4cd273d
fix(igxHGrid): Check VisibleColumnIndex is not greater than columns l…
Jan 10, 2020
bb4963f
chore(*): Fixing typo mistake
Jan 10, 2020
571cea5
Merge branch 'master' into mdragnev/fix-5126-master
ChronosSF Jan 13, 2020
1fc8e77
chore(*): code refactoring
Jan 14, 2020
d70a555
chore(*): Code refactoring
Jan 14, 2020
6fc3cd5
Merge branch 'master' into mdragnev/fix-5126-master
ChronosSF Jan 15, 2020
8e0e45e
Merge branch 'master' into mdragnev/fix-5126-master
ChronosSF Jan 17, 2020
72bdca3
Merge branch 'master' into mdragnev/fix-5126-master
ChronosSF Jan 17, 2020
7bce024
Merge branch 'master' into mdragnev/fix-5126-master
ChronosSF Jan 17, 2020
965a095
Merge branch 'master' into mdragnev/fix-5126-master
ChronosSF Jan 17, 2020
dc813e7
Merge branch 'master' into mdragnev/fix-5126-master
ChronosSF Jan 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .../igniteui-angular/src/lib/grids/hierarchical-grid/hierarchical-grid-navigation.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -668,6 +668,8 @@ export class IgxHierarchicalGridNavigationService extends IgxGridNavigationServi
}

private focusNextRow(elem, visibleColumnIndex, grid, isSummary?) {
const lastCellIndex = grid.unpinnedColumns[grid.unpinnedColumns.length - 1].visibleIndex;
visibleColumnIndex = Math.min(lastCellIndex, visibleColumnIndex);
const cellSelector = this.getCellSelector(visibleColumnIndex, isSummary);
if (grid.navigation.isColumnFullyVisible(visibleColumnIndex) || grid.rowList.length === 0) {
const cell =
Expand Down Expand Up @@ -700,6 +702,8 @@ export class IgxHierarchicalGridNavigationService extends IgxGridNavigationServi
}

private focusPrevRow(elem, visibleColumnIndex, grid, inChild?, isSummary?) {
const lastCellIndex = grid.unpinnedColumns[grid.unpinnedColumns.length - 1].visibleIndex;
visibleColumnIndex = Math.min(lastCellIndex, visibleColumnIndex);
if (grid.navigation.isColumnFullyVisible(visibleColumnIndex)) {
const cellSelector = this.getCellSelector(visibleColumnIndex, isSummary);
const cells = elem.querySelectorAll(`${cellSelector}[data-visibleIndex="${visibleColumnIndex}"]`);
Expand Down