Skip to content

fix(slider): subscribe for resizeObservable cb outside zone #6502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rkaraivanov merged 2 commits into from
Jan 22, 2020
Merged

fix(slider): subscribe for resizeObservable cb outside zone #6502

rkaraivanov merged 2 commits into from
Jan 22, 2020

Conversation

@Aleksandyr
Copy link
Contributor

@Aleksandyr Aleksandyr commented Jan 21, 2020 •
edited
Loading

Closes #6500

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@Aleksandyr Aleksandyr added ❌ status: awaiting-test PRs awaiting manual verification slider labels Jan 21, 2020
@rkaraivanov rkaraivanov added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Jan 22, 2020
@rkaraivanov rkaraivanov merged commit 0f02748 into master Jan 22, 2020
@rkaraivanov rkaraivanov deleted the infinite-loop-resizeObservable branch January 22, 2020 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rkaraivanov rkaraivanov rkaraivanov approved these changes

Assignees

@rkaraivanov rkaraivanov

Labels

slider ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

An Infinite loop is caused when open slider in IE11 or edge

3 participants

@Aleksandyr @rkaraivanov