Upgrade excludePositionTarget to a collection of HTML Elements #8281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to a collection of HTMLElements
closeOnOutsideClick is false.
-refactor drop-down handlers & directly use the new methods in select
…s://github.com/IgniteUI/igniteui-angular into iganchev/excludepositiontarget-collection-8148
wnvko
requested changes
Oct 6, 2020
Contributor
wnvko
left a comment
wnvko
left a comment
There was a problem hiding this comment.
Add test for this in overlay.spec.ts
projects/igniteui-angular/src/lib/directives/toggle/toggle.directive.ts
Outdated
Show resolved
Hide resolved
projects/igniteui-angular/src/lib/directives/autocomplete/autocomplete.directive.ts
Outdated
Show resolved
Hide resolved
wnvko
previously approved these changes
Oct 7, 2020
14 tasks
for excludeFromOutsideClick.
…s://github.com/IgniteUI/igniteui-angular into iganchev/excludepositiontarget-collection-8148
wnvko
approved these changes
Oct 7, 2020
14 tasks
Lipata
added
💥 status: in-test
Lipata
added
✅ status: verified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8148
Closes #7974
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)