fix(grid): Exec onOpening only once for esf #8138 #8283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astaev
added
grid: excel-style-filtering
grid: general
❌ status: awaiting-test
onlyexeption
reviewed
Oct 8, 2020
projects/igniteui-angular/src/lib/grids/filtering/grid-filtering.service.ts
Outdated
Show resolved
Hide resolved
onlyexeption
added
✅ status: verified
DiyanDimitrov
suggested changes
Oct 8, 2020
...teui-angular/src/lib/grids/filtering/excel-style/excel-style-conditional-filter.component.ts
Outdated
Show resolved
Hide resolved
projects/igniteui-angular/src/lib/grids/headers/grid-header.component.ts
Outdated
Show resolved
Hide resolved
projects/igniteui-angular/src/lib/grids/filtering/grid-filtering.service.ts
Outdated
Show resolved
Hide resolved
DiyanDimitrov
suggested changes
Oct 8, 2020
Contributor
DiyanDimitrov
left a comment
DiyanDimitrov
left a comment
There was a problem hiding this comment.
Add a unit test to cover the scenario.
...teui-angular/src/lib/grids/filtering/excel-style/excel-style-conditional-filter.component.ts
Outdated
Show resolved
Hide resolved
projects/igniteui-angular/src/lib/grids/filtering/grid-filtering.service.ts
Outdated
Show resolved
Hide resolved
DiyanDimitrov
approved these changes
Oct 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8138
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)