fix(migrations): migrate GridPagingMode via members.json #9984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViktorSlavov
added
migrations
❌ status: awaiting-test
damyanpetev
reviewed
Aug 11, 2021
| templateUrl: "./paging-test.component.html" | ||
| }) | ||
| export class CsvExportComponent { | ||
| public pagingLocal: GridPagingMode = GridPagingMode.local; |
Member
There was a problem hiding this comment.
I know it's pending, but shouldn't this be GridPagingMode.Local with capital as the migration is expected to replace?
Lipata
approved these changes
Aug 12, 2021
jackofdiamond5
added
💥 status: in-test
jackofdiamond5
approved these changes
Aug 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #9927
Changes to TsServerHost and handling of ngLS introduced in this PR force
UpdateChange.getLanguageServiceForFile()to work only with absolute paths. This breaks the migration forGridPagingModein11.1.x(which uses relative paths).That migration is now moved to the
members.json(as IvyLS enables it to work).Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)