check profile length before reading header in GetIPTCStream#8829
Merged
Conversation
dlemstra
approved these changes
Jun 29, 2026
Contributor
Author
|
Thank you for reviewing and merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
GetIPTCStream in coders/meta.c reads the first two bytes of the 8bim/iptc profile (
*pand*(p+1)) before it has checked that the profile actually holds two bytes, so a profile shorter than that is read past its declared length. The profile content comes from the input image, and the read is reached when writing it out through the iptc, iptctext or 8bimtext coders. Every later read in the same function is already guarded by an extent check (for instanceif (extent < 4) breakbefore the four-byte tag length), so this just adds the matching guard for that first read and returns zero when there is nothing to parse, which leaves valid profiles untouched.