Skip to content

page-text-updates#2

Merged
jasonam84 merged 1 commit into
mainfrom
about-page-text-updates
May 23, 2026
Merged

page-text-updates#2
jasonam84 merged 1 commit into
mainfrom
about-page-text-updates

Conversation

@jasonam84

Copy link
Copy Markdown
Contributor
  • Community Values
  • Code of Conduct
  • Institute Faculty & Staff
  • NextGens
  • Collaborators
  • Subscribe to mailing list
  • Visiting Traveler Instructions

@jasonam84

jasonam84 commented May 14, 2026

Copy link
Copy Markdown
Contributor Author
Community Values Code of Conduct Staff NextGens Collaborators Mailing List

@jasonam84 jasonam84 requested a review from egrace479 May 21, 2026 18:35

@egrace479 egrace479 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran it locally, all the updated pages seem to work; checked all the links. The search populates, but the links give 404 errors (e.g., with code of conduct). I'm guessing this will be a later implementation/update, so approving for now with one inline update.

Comment thread html/about/nextgens.html
<li><strong>Luke Song</strong>, Ohio State</li>
<li><strong>Sam Stevens</strong>, Ohio State</li>
<li><strong>Oshane Thomas</strong>, Seattle Children's Hospital</li>
<li><strong>Nina can Tiel</strong>, EPFL</li>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<li><strong>Nina can Tiel</strong>, EPFL</li>
<li><strong>Nina van Tiel</strong>, EPFL</li>

I checked and the website does have it wrong...

@jasonam84

Copy link
Copy Markdown
Contributor Author

Ran it locally, all the updated pages seem to work; checked all the links. The search populates, but the links give 404 errors (e.g., with code of conduct). I'm guessing this will be a later implementation/update, so approving for now with one inline update.

the search hasn't been touched at all; just waiting for everything to be done before i work on that file.

@jasonam84 jasonam84 merged commit 83db0ad into main May 23, 2026
@jasonam84 jasonam84 deleted the about-page-text-updates branch May 23, 2026 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants