Add preceding point and iterable filters#382
Draft
Tom Holland (tomjholland) wants to merge 4 commits into
Draft
Conversation
…ring - Introduce _Filter class encapsulating group-filtering logic for a single column and optional row condition, with singular() and plural() methods for one-shot and iterative use respectively - Add include_preceding_point flag to include the row immediately before each contiguous block of selected rows - Replace _filter_numerical with composable mask primitives: _RankExprs, _span_mask, _point_mask, _combined_mask, and _nonbounded_slice_mask for full slice semantics (negative indices, open-ended bounds, step > 1) - Add _group_start_expr to correctly compute dense ranks under an arbitrary row condition without materialising an intermediate frame - plural() uses a zero-collect static path for bounded index types; falls back to a single collect for open-ended slices and None - Expand test suite to cover all new index forms and filter types
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #382 +/- ##
==========================================
+ Coverage 95.42% 95.89% +0.47%
==========================================
Files 58 58
Lines 5003 5535 +532
==========================================
+ Hits 4774 5308 +534
+ Misses 229 227 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.