harden: -Werror=implicit-function-declaration (Makefile + build.sh) - #240
Merged
Conversation
An implicitly-declared function is assumed to return int, so on 64-bit a pointer-returning libc/GNU function compiled without its prototype gets its return truncated to 32 bits and sign-extended — a corrupted pointer that segfaults at runtime, layout-dependently. That class caused the ext_http strcasestr/_GNU_SOURCE remote-DoS (#239) and passed CI as a mere warning (no -Werror; the runtime crash didn't trigger on the CI runners' heap layout). Make the whole class a hard build error. The buildable surface (default + http + model) is warning-clean under -Wall -Wextra, and there are zero implicit declarations anywhere checkable locally, so this is a no-op today — purely a regression gate. Added to both the Makefile CFLAGS and build.sh (the release drift-guard) so they don't diverge. gfx/db legs can't be compiled here (missing SDL/libpq headers); CI verifies those + the macOS clang leg. Behavior unchanged (build-flag only). Default + http build clean; smoke OK. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
InauguralPhysicist
added a commit
that referenced
this pull request
Jun 19, 2026
… recovery Patch release on top of 0.16.0. Highlights: - Remote HTTP DoS fixed (Content-Length SEGV; missing _GNU_SOURCE → 64-bit pointer truncation) and the implicit-declaration class hard-errored in the build (#239/#240). - ASan leak tally driven 10 → 4 (spawn-thread floor) across the runtime, HTTP code routes, container builtins, and the store extension (#234/#235/#236/#233). - OSR/JIT coverage for observed-assign loops recovered: #211's conservative scanner bail replaced by the real fix — reset the OP_POP last_imm peephole at forward-jump targets — so those loops OSR-compile again (~34%, #231). - Docs: clarified the implicit-`n` parameter shadows an outer `n` (#241, not a bug). Also repairs CHANGELOG drift: commit 8fe0731 had accidentally deleted the `## [0.16.0] — 2026-06-18` header, folding released 0.16.0 content back into [Unreleased]. The header is restored (with its summary), the windowed-predicate + #212/#213/#214 entries are reattributed to 0.16.0 (their code shipped in the v0.16.0 tag), and everything post-tag is grouped under the new [0.16.1]. VERSION 0.16.0 → 0.16.1. Release 1943/1943; ASan 1943/1943, leak tally 4. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An implicitly-declared function is assumed to return int, so on 64-bit a pointer-returning libc/GNU function compiled without its prototype gets its return truncated to 32 bits and sign-extended — a corrupted pointer that segfaults at runtime, layout-dependently. That class caused the ext_http strcasestr/_GNU_SOURCE remote-DoS (#239) and passed CI as a mere warning (no -Werror; the runtime crash didn't trigger on the CI runners' heap layout). Make the whole class a hard build error.
The buildable surface (default + http + model) is warning-clean under -Wall -Wextra, and there are zero implicit declarations anywhere checkable locally, so this is a no-op today — purely a regression gate. Added to both the Makefile CFLAGS and build.sh (the release drift-guard) so they don't diverge. gfx/db legs can't be compiled here (missing SDL/libpq headers); CI verifies those + the macOS clang leg.
Behavior unchanged (build-flag only). Default + http build clean; smoke OK.
What does this PR do?
Checklist
make testpasses locallydocs/BUILTINS.mddocs/STDLIB.md