Fix #327: grow parser statement arrays instead of silently truncating - #342
Merged
Conversation
parse() and parse_block stored statements into fixed 4096-entry arrays and silently discarded everything past the cap — a 100k-statement program executed only its first 4096 statements and exited 0; a define body past the cap lost its return and yielded null. Both arrays now grow on demand (and blocks no longer preallocate 32KB each — 256-deep nesting used to reserve ~8MB). Removing the cap exposes a pre-existing quadratic compile cost on programs with tens of thousands of unique module-scope names (NameSet linear-scan dedup) — filed as #341; single-name programs are linear. Regression: suite [111] test_stmt_cap.eigs (4200-statement program and block run in full, 40ms). Release + ASan(detect_leaks=1) 2350/2350, leak tally 0. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parse()andparse_blocksilently dropped statements past a fixed 4096 cap (program level: tail never ran, rc=0; block level: a bigdefinelost itsreturnand yielded null)MAX_STMTSremoved from eigenscript.h (parser was its only user)Closes #327.
Removing the cap exposed a pre-existing O(n²) compile cost on programs with many unique module-scope names — filed separately as #341 (normal and single-name generated programs unaffected).
Validation
test_stmt_cap.eigs: 4200-statement program + 4200-statement function body run in full (both silently truncated before); 40msdetect_leaks=12350/2350, leak tally 0🤖 Generated with Claude Code