ui: waveform_view selection edge markers + fill clamp - #610
Merged
Conversation
The selection fill is a deliberately faint alpha-30 tint, so a
selection spanning the whole visible range rendered as a uniform wash
with no boundary — imperceptible. DeslanStudio driven QA: Select All
set the model selection and repainted, but a human could not tell,
so Duplicate/Cut/etc appeared broken ("can't seem to duplicate").
Each selection edge now draws a full-strength vertical line in the
widget color when it lies inside the visible span, and the fill rect
is clamped to widget bounds instead of trusting sel/zoom arithmetic.
Suite: 2931/2931.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This was referenced Jul 14, 2026
InauguralPhysicist
added a commit
that referenced
this pull request
Jul 14, 2026
Version bump + CHANGELOG [Unreleased]->[0.31.0] + CLAUDE.md latest-release line. Batch: bulk audio-I/O kernels (#602/#603), live audio-streaming primitive (#612, the sustain path behind DeslanStudio musical typing), waveform_view selection edge markers (#610/#611). NOTE: doc-drift rule 2 (Latest-release line vs latest tag) only passes once the release workflow creates the v0.31.0 tag — dispatch after merge. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Driven-QA find (DeslanStudio): Select All read as a dead button — the model selected and the widget repainted, but the selection fill is a faint alpha-30 tint, so a full-range selection is a uniform wash with no visible boundary. Pixel-verified: background went (18,18,26) → (25,34,53) everywhere, which no human perceives without an edge.
sel/zoomarithmetic could paint outside the widget when scrolled/zoomed).Suite 2931/2931; interaction tests in test_ui.eigs unaffected (render-only change).
🤖 Generated with Claude Code