fix: pane title respects session rename#75
Merged
Merged
Conversation
… title - Scroll lock: in TerminalPanel flushPendingData, snapshot linesFromBottom before each term.write and restore via term.scrollLines() if the buffer trim shrank the distance. Keeps viewport pinned when user is scrolled up. - Pane title: updateTerminalTitleFromSession now reads sessionNameOverrides before falling back to session.summary, so renamed AI sessions keep their name in the pane title (matching CopilotPanel session list behavior). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
omer91se
force-pushed
the
omersegal/new-branch
branch
from
23318d9 to
354d100
Compare
omer91se
changed the title
The flushPendingData scroll-lock callback caused selection and wheel scrolling to freeze in 3 of 4 panes. Reverting to plain term.write while a less invasive approach is designed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
omer91se
changed the title
yoziv
added a commit
to yoziv/tmax
that referenced
this pull request
Apr 29, 2026
Pure-function tests (run without Electron packaging): - PR InbarR#53/InbarR#56: extractLinkFromHtml + unwrapSafelinks (16 tests) Extracted to src/renderer/utils/link-extract.ts, shared by TerminalPanel.tsx and DetachedApp.tsx (deduplication) - PR InbarR#57: path traversal guard (10 tests) Extracted to src/main/utils/security-guards.ts - PR InbarR#58: OPEN_PATH extension blocklist (28 tests) - PR InbarR#60: WSL distro name validation (9 tests) E2E tests (require npm run package): - PR InbarR#75: session rename propagates to pane title - PR InbarR#13: minimum pane size enforcement - PR InbarR#14: DEC focus sequence injection on pane switch - PR InbarR#9: ShortcutsHelp escape in capture phase - PR InbarR#10: pane title doesn't overlap terminal content - PR InbarR#8: shifted key character in Ctrl+Shift+/ binding Also extracts duplicated link-extract functions from TerminalPanel.tsx and DetachedApp.tsx into a shared utility. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Apr 29, 2026
InbarR
pushed a commit
that referenced
this pull request
May 2, 2026
Pure-function tests (run without Electron packaging): - PR #53/#56: extractLinkFromHtml + unwrapSafelinks (16 tests) Extracted to src/renderer/utils/link-extract.ts, shared by TerminalPanel.tsx and DetachedApp.tsx (deduplication) - PR #57: path traversal guard (10 tests) Extracted to src/main/utils/security-guards.ts - PR #58: OPEN_PATH extension blocklist (28 tests) - PR #60: WSL distro name validation (9 tests) E2E tests (require npm run package): - PR #75: session rename propagates to pane title - PR #13: minimum pane size enforcement - PR #14: DEC focus sequence injection on pane switch - PR #9: ShortcutsHelp escape in capture phase - PR #10: pane title doesn't overlap terminal content - PR #8: shifted key character in Ctrl+Shift+/ binding Also extracts duplicated link-extract functions from TerminalPanel.tsx and DetachedApp.tsx into a shared utility. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Single fix on top of fresh
main: the pane title now stays in sync when an AI session is renamed.Changes
Pane title respects session renames (
src/renderer/state/terminal-store.ts)updateTerminalTitleFromSessionnow readssessionNameOverrides[session.id]first and falls back tosession.summaryonly if no override exists. This matches the behavior of the CopilotPanel session list, so renaming an AI session keeps the new name in the pane title instead of reverting to the auto-generated summary.Dependency
Installed missing
@xterm/addon-serialize(was listed inpackage.jsonbut absent fromnode_modules); onlypackage-lock.jsonchanged.Reverted in this PR
A scroll-lock-during-output change was applied earlier (commit 354d100) but reverted in 432012f because the per-flush
term.scrollLines()callback froze selection and wheel scrolling in 3 of 4 panes. A less invasive approach (e.g. wheel/scroll listener that only intervenes when the buffer just trimmed) will be designed in a follow-up.Testing