test: add regression tests for 12 merged PRs#82
Closed
yoziv wants to merge 1 commit into
Closed
Conversation
Pure-function tests (run without Electron packaging): - PR InbarR#53/InbarR#56: extractLinkFromHtml + unwrapSafelinks (16 tests) Extracted to src/renderer/utils/link-extract.ts, shared by TerminalPanel.tsx and DetachedApp.tsx (deduplication) - PR InbarR#57: path traversal guard (10 tests) Extracted to src/main/utils/security-guards.ts - PR InbarR#58: OPEN_PATH extension blocklist (28 tests) - PR InbarR#60: WSL distro name validation (9 tests) E2E tests (require npm run package): - PR InbarR#75: session rename propagates to pane title - PR InbarR#13: minimum pane size enforcement - PR InbarR#14: DEC focus sequence injection on pane switch - PR InbarR#9: ShortcutsHelp escape in capture phase - PR InbarR#10: pane title doesn't overlap terminal content - PR InbarR#8: shifted key character in Ctrl+Shift+/ binding Also extracts duplicated link-extract functions from TerminalPanel.tsx and DetachedApp.tsx into a shared utility. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds regression tests covering 12 merged PRs that had no test coverage.
Pure-function tests (76 assertions, run in ~1s without packaging)
E2E tests (require npm run package)
Refactoring
src/renderer/utils/link-extract.tssrc/main/utils/security-guards.ts