Add an adventure text colour parser#59
Merged
Merged
Conversation
broccolai
previously requested changes
Oct 16, 2020
Member
broccolai
left a comment
broccolai
left a comment
There was a problem hiding this comment.
Suggestions still appear red when going onto the next one
Citymonstret
force-pushed
the
features/1.1.0/colours
branch
from
a864066 to
cd00c2a
Compare
Member
|
Maybe we could have multiple modes for the parser. |
Citymonstret
force-pushed
the
features/1.1.0/colours
branch
from
cd00c2a to
6469bb3
Compare
Citymonstret
force-pushed
the
features/1.1.0/colours
branch
from
6469bb3 to
c8a27e2
Compare
jpenilla
approved these changes
Oct 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Untested Should probably be tested before merging.