Fix infinite recursion when a @Suggestions method returns a CompletableFuture#771
Merged
jpenilla merged 2 commits intoIncendo:masterfrom Sep 11, 2024
Merged
Conversation
Test Results 88 files ±0 88 suites ±0 10s ⏱️ -4s Results for commit c9e7dd4. ± Comparison against base commit 8c3d2e6. This pull request removes 3 and adds 4 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
jpenilla
approved these changes
Sep 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MethodSuggestionProvider#mapSuggestionscalls itself when the method's input (the@Suggestionsmethod return value) is aCompletableFuture, instead of the unused#mapFuture, leading to aStackOverflowError.