lsp: make goto/hover follow the checker resolution instead of name-scans

[0xGeorgii]

Fixes #245. Stacked on #267 (244-bug-fix-hit-test-coverage-gaps) — merge that first.

Goto/hover no longer contradict the type checker. All six items; every positive test was empirically verified to FAIL on the base branch pre-fix (via a detached base worktree running the same public-API tests).

Changes

• Free-fn vs same-named method: when the checker resolved a call with receiver_struct=None (explicitly not a method), goto and hover's callee_signature restrict the by-name search to non-method defs (new find_free_def_by_name: top-level + spec-nested, skipping struct methods).
• Selective imports: goto_value_def consults only braced imports whose imported_types name the bare value — a plain use m; no longer resolves bare names (matching the checker, which rejects them).
• pub use re-export chains: new recursive resolve_exported_value follows re-exports to the defining file, with a visited-set cycle guard.
• Qualified-type hover: lib::T hover resolves through the qualifier the way goto does (new type_ident_signature/qualified_member_signature).
• Function-type rendering: the TypeInfoKind::Function carrier is now a source-like fn(...) -> ret instead of the internal Function<2, i32>. Caveat, documented in the code: the parser deliberately drops written fn(...) parameter types when lowering (pinned AST-parity quirk), so hovers on real parsed source show fn() -> i32; actual params are threaded whenever present. Fixing the parser to preserve them would break the AST-parity contract — out of scope here.
• full_range consistency: goto on a local-binding use now returns the whole declaration statement as full_range with the ident as focus, matching the declaration-site path.

Testing

10 new ide-level probe tests mirroring the issue repros + 2 updated checker unit tests pinning the new carrier (fn(i32, bool) -> string, fn() -> unit). inference-ide 141/141, inference-tests 2299/2299, full default-workspace cargo test 4411 passed / 0 failed; clippy clean.

Confidence Score: 4/5

Safe to merge with one focused fix: resolve_exported_value uses find_def_by_name (which walks struct methods) instead of find_free_def_by_name, leaving a narrow goto mis-navigation for modules that export both a struct method and a top-level value with the same name.

resolve_exported_value — the new function that follows pub use re-export chains — calls find_def_by_name, which includes struct methods in the pre-order flatten. If an exported module has a public struct method and a public top-level function sharing a name (exactly the scenario the rest of this PR corrects), goto can still land on the method instead of the function when the value was imported via a re-export chain. The rest of the PR is clean and well-tested.

ide/ide/src/goto_definition.rs — specifically resolve_exported_value at line 262, where find_def_by_name should be find_free_def_by_name.

Important Files Changed

Filename	Overview
ide/ide/src/goto_definition.rs	Core fix file — introduces find_free_def_by_name for calls, selective-import filtering, and resolve_exported_value for re-export chains; resolve_exported_value still calls find_def_by_name (which includes struct methods) instead of find_free_def_by_name, leaving the same-named method bug class it was meant to fix.
ide/ide/src/hover.rs	Hover correctly adopts find_free_def_by_name for free-call signatures and adds type_ident_signature/qualified_member_signature for qualified-type hover; logic mirrors goto's qualifier resolution cleanly.
ide/ide/src/syntax.rs	Adds find_free_def_by_name and its helper non_method_defs/collect_non_method_def; implementation is correct — pushes top-level and spec-nested defs while skipping struct methods.
core/type-checker/src/type_info.rs	Function-type carrier changed from Function<N, Ret> to fn(params) -> ret using a new source_like_spelling helper; correctly handles nested function types and builtin/custom type spellings.
tests/src/type_checker/type_info_tests.rs	Two unit tests updated to pin the new fn() -> unit / fn(i32, bool) -> string carrier format.
CHANGELOG.md	Adds the #245 changelog entry and backlink; content accurately describes the six fixes introduced in this PR.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[goto_definition / hover at offset] --> B{node kind?}
    B -->|Expr: Identifier call| C[goto_call / callee_signature]
    B -->|Expr: Identifier value| D[resolve_local?]
    B -->|Type node| E[type_ident_signature]
    B -->|Use directive| F[goto_in_directive]
    C --> C1{receiver_struct?}
    C1 -->|Some struct| C2[find_def_by_name to find_method]
    C1 -->|None free call| C3[find_free_def_by_name OK]
    D -->|found local| D1[nav_at_ident with full stmt range]
    D -->|not local| G[goto_value_def]
    G --> G1[find_def_by_name in entry file]
    G1 -->|not found| G2{braced import names it?}
    G2 -->|yes| G3[resolve_exported_value]
    G2 -->|no plain use| G4[None matches checker]
    G3 --> G5[find_def_by_name WARN should be find_free_def_by_name]
    G5 -->|not found or pub use| G6[follow pub use re-export chain with cycle guard]
    E --> E1{qualified lib T?}
    E1 -->|yes| E2[qualified_member_signature via resolve_qualified_module]
    E1 -->|bare type| E3[type_name_signature]
    F --> F1[find_def_by_name direct WARN no re-export follow]

Loading

%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A[goto_definition / hover at offset] --> B{node kind?}
    B -->|Expr: Identifier call| C[goto_call / callee_signature]
    B -->|Expr: Identifier value| D[resolve_local?]
    B -->|Type node| E[type_ident_signature]
    B -->|Use directive| F[goto_in_directive]
    C --> C1{receiver_struct?}
    C1 -->|Some struct| C2[find_def_by_name to find_method]
    C1 -->|None free call| C3[find_free_def_by_name OK]
    D -->|found local| D1[nav_at_ident with full stmt range]
    D -->|not local| G[goto_value_def]
    G --> G1[find_def_by_name in entry file]
    G1 -->|not found| G2{braced import names it?}
    G2 -->|yes| G3[resolve_exported_value]
    G2 -->|no plain use| G4[None matches checker]
    G3 --> G5[find_def_by_name WARN should be find_free_def_by_name]
    G5 -->|not found or pub use| G6[follow pub use re-export chain with cycle guard]
    E --> E1{qualified lib T?}
    E1 -->|yes| E2[qualified_member_signature via resolve_qualified_module]
    E1 -->|bare type| E3[type_name_signature]
    F --> F1[find_def_by_name direct WARN no re-export follow]

Loading

Comments Outside Diff (3)

1. ide/ide/src/goto_definition.rs, line 472-496 (link)

   Directive navigation doesn't follow re-export chains

   goto_in_directive calls find_def_by_name(arena, sfid, name) directly on the immediate target module. If that module only re-exports the name (e.g. mid has pub use lib::{MAX} but no own MAX definition), find_def_by_name returns None and the directive-level navigation silently fails. The new resolve_exported_value used in goto_value_def would handle this correctly, but it isn't wired in here, creating an asymmetry: clicking MAX in use mid::{MAX} at the use-site now resolves all the way to lib, while clicking MAX in the same use directive text does not.

2. ide/ide/src/goto_definition.rs, line 225-228 (link)

   resolve_exported_value uses find_def_by_name, which includes struct methods

   find_def_by_name calls file_defs under the hood, which is a pre-order flatten that covers struct methods. If an exported module has a struct method named NAME that appears before a public top-level constant/function named NAME in source order, find_def_by_name returns the method, and—since def_is_public can be true for a method—goto navigates to the wrong definition. This is exactly the same bug class that motivated introducing find_free_def_by_name in goto_call. resolve_exported_value is a new function added in this PR and should use find_free_def_by_name for consistency: it is only ever called to resolve bare exported values (constants, functions, types), never struct methods.

3. ide/ide/src/goto_definition.rs, line 262-266 (link)

   find_def_by_name includes struct methods via file_defs. When a module has both a public struct method named NAME and a public top-level constant/function named NAME, and the method appears earlier in source order, resolve_exported_value returns the method instead of the top-level def—navigating to the wrong place. find_free_def_by_name was introduced in this PR for exactly this reason and should be used here too.

_{Reviews (3): Last reviewed commit: "Merge branch 'main' into 245-bug-fix-got..." | Re-trigger Greptile}

Greptile also left 1 inline comment on this PR.

[codecov]

Codecov Report

❌ Patch coverage is 97.41379% with 6 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
ide/ide/src/syntax.rs	87.50%	3 Missing ⚠️
ide/ide/src/hover.rs	97.22%	2 Missing ⚠️
ide/ide/src/goto_definition.rs	99.19%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!