feat(nccl): add point-to-point communication - #58
Draft
voltjia wants to merge 1 commit into
Draft
Conversation
53 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add NVIDIA NCCL implementations for
infinicclSendandinfinicclRecv, while preserving communicator-aware fallback to an available backend. The branch is stacked on #57 so provider header changes reliably regenerate the generated bridge.Changes
Send/Recvproviders.ncclSendandncclRecv.kNotSupportedinstead of entering an unavailable template dispatch and aborting.Platform and Backend Affected
Platform
Backend
Performance Impact
N/A. No performance claim is made; the change adds a previously unavailable NCCL operation.
Known Issues & Future Work
masterafter fix(build): regenerate communication bridge for header changes #57 merges.Test Results
Test environment:
ssh nvidia,accelerator-dev/nvidia:latest, two NVIDIA A100-SXM4-80GB GPUs.examples/ccl/send_recvpassed on two A100 GPUs and received the expected value7.0.examples/ccl/all_reducepassed as a regression check.mpirun -np 2 examples/mpi/send_recvpassed and received the expected data.git diff --checkpassed.Test Involved Platform
Test Involved Backend
Checklist
Title, Branch, and Commits
<type>/xxx-yyyy-zzzz.master.fixup!/squash!/wipcommits remain.Scope and Design
Send/Recvbehavior is intentional and covered by examples and tests.General Code Hygiene
C++ Specific
Python Specific
N/A: No Python files are changed by this PR.
Testing
Build, CI, and Tooling
Documentation
Security and Safety