refactor(ops): migrate activation adapters to canonical InfiniOps APIs - #1468
Closed
voltjia wants to merge 1 commit into
Closed
refactor(ops): migrate activation adapters to canonical InfiniOps APIs#1468voltjia wants to merge 1 commit into
voltjia wants to merge 1 commit into
Conversation
Collaborator
Author
|
Superseded by #1480, which consolidates the canonical InfiniOps adapter migrations while preserving each logical change as a separate commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ReluInfinilmto canonicalReluSiluAndMulInfinilmto canonicalSiluAndMulAPI alignment
ReluInfinilm::Call(handle, config, input, out)Relu::Call(handle, config, input, out)torch.nn.functional.relu(input, inplace=False). InfiniOps retains its C++ input/output convention while using the canonical operator name and unary input contract.SiluAndMulInfinilm::Call(handle, config, input, out)SiluAndMul::Call(handle, config, input, out)SiluAndMul.forward(x) -> Tensor, withx[..., :d]gated by SiLU and multiplied byx[..., d:]. InfiniOps exposes the same single-input contract with an explicit output tensor.The currently pinned InfiniOps commit (
1b9c37659211eeaeedb48b9691f79e4c9e4412f9) already provides both canonical operators, so this PR does not update the submodule.Validation
Validated commit
0dbf6e0dremotely onssh nvidiawithaccelerator-dev/nvidia:latest:_infinicorefrom a clean checkout with the exact pinned submoduleslibinfinicore_cpp_api.soresolveslibinfiniops.sofrom the exact installed packagepython3 test/infinicore/ops/silu_and_mul.py --nvidia: 36/36 passed across FP16, BF16, FP32, functional, and out-parameter casesinfinicore::op::reluon NVIDIA; device execution and host result comparison passedclang-format-16 --dry-run --Werrorpassed for both changed filesgit diff --checkpassed