refactor(ops): migrate rearrange to canonical InfiniOps API - #1469
Closed
voltjia wants to merge 1 commit into
Closed
refactor(ops): migrate rearrange to canonical InfiniOps API#1469voltjia wants to merge 1 commit into
voltjia wants to merge 1 commit into
Conversation
Collaborator
Author
|
Superseded by #1480, which consolidates the canonical InfiniOps adapter migrations while preserving each logical change as a separate commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RearrangeInfinilmto canonicalCopynon_blocking=false, matching the legacy synchronous same-device behaviorAPI alignment
RearrangeInfinilm::Call(handle, config, src, out)Copy::Call(handle, config, src, false, out)Tensor.copy_(src, non_blocking=False). InfiniOps preservessrc, non_blockingand represents the mutable receiver as the trailing explicitouttensor per its input-attribute-output convention.Dependency
This PR is based on
refactor/migrate-paged-caching-infiniops/ #1467 because that branch advances the InfiniOps gitlink toe733e325b4af776261419e4dc7e1f9386c05fa71, which includes the canonicalCopyoperator from InfiniOps #872.Against #1467, this PR changes one file with three insertions and three deletions. After #1467 merges, this PR can be retargeted to
mainwithout carrying an additional submodule update.Validation
Validated commit
e89ff869remotely onssh nvidiawithaccelerator-dev/nvidia:latest, using the exact InfiniOps gitlinke733e325:_infinicorewith the canonicalcopyprovider in the wrapper allowlistrearrange_impl::infiniops::plan,run, andcleanupon an NVIDIA tensor; copied values and plan cleanup were verifiedclang-format 16.0.6 --dry-run --Werrorpassed for the changed filegit diff --checkpassed