refactor(ops): use InfiniOps Convolution for conv2d - #1479
Closed
voltjia wants to merge 1 commit into
Closed
Conversation
Collaborator
Author
|
Superseded by #1480, which consolidates the canonical InfiniOps adapter migrations while preserving each logical change as a separate commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
ConvInfinilmwith the canonical InfiniOpsConvolutionAPI.transposed=false, zerooutput_padding, andgroups=1.Alignment
conv2dConvolution(input, weight, bias, stride, padding, dilation, transposed=false, output_padding=0, groups=1, out)torch.nn.functional.conv2d(input, weight, bias, stride, padding, dilation, groups), ATenconvolutionschema, InfiniOpsConvolution, InfiniOps #882The call follows InfiniOps' C++ input/attribute/output ordering and maps the non-transposed conv2d subset onto the full PyTorch/ATen convolution contract.
Why
The old InfiniLM convolution provider now backs the canonical
Convolutionoperator, so the deprecatedConvInfinilmclass is no longer required by InfiniCore.Scope
This is stacked on #1478. It does not expand conv2d feature support or change the public InfiniCore API.
Screenshots: N/A (backend adapter migration only).
Validation
Run on
ssh nvidiainaccelerator-dev/nvidia:lateston NVIDIA A100 GPUs:infinicore_cpp_apiand_infinicorebuild/install passed.python3 scripts/format.py --ref 850fb3f7 --path src --checkwith clang-format 16.0.6.git diff --check.