feat(cuda): add canonical GELU and sigmoid providers - #889
Merged
Conversation
voltjia
force-pushed
the
feat/add-canonical-activation-providers
branch
from
August 7, 2026 07:45
498c9aa to
1722a08
Compare
19 tasks
This was referenced Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GeluandSigmoidCUDA providers for NVIDIA, Iluvatar, MetaX, and Moore.Gelucoverage for both supported approximation modes.Motivation
InfiniCore still uses the deprecated
GeluInfinilm,GeluTanhInfinilm, andSigmoidInfinilmcompatibility operators. Canonical provider coverage is required before those adapters can migrate to the PyTorch-aligned operator names.Type of Change
feat- new feature / new operator / new platformfix- bug fixperf- performance improvement (no behavioral change)refactor- code restructuring without behavior changetest- adding or fixing tests onlydocs- documentation onlybuild/ci- build system or CI configurationchore- tooling, formatting, or other non-code changes!in the Conventional Commits prefix or aBREAKING CHANGE:footer)Platforms Affected
WITH_CPU)WITH_NVIDIA)WITH_ILUVATAR)WITH_METAX)WITH_CAMBRICON)WITH_MOORE)WITH_ASCEND)WITH_TORCH)Smoke Test Result
Validated on
ssh nvidiainaccelerator-dev/nvidia:latestas part of the canonical-provider integration stack:Test Results on Supported Platforms
Benchmark / Performance Impact
N/A. The canonical providers reuse existing kernels.
Notes for Reviewers
The public schemas already existed; this PR adds native provider coverage and the metadata needed by the generic implementations.
Gelu(input, approximate, out)torch.nn.functional.gelu(input, approximate='none')Sigmoid(input, out)torch.sigmoid(input, *, out=None)InfiniOps uses an explicit trailing output tensor for its C++ API. This PR does not add overloads or remove the deprecated InfiniLM compatibility classes. The vendor backend headers are thin wrappers around the shared CUDA implementations.
The NVIDIA result validates the NVIDIA provider and shared kernels. Iluvatar, MetaX, and Moore platform CI remain required.