feat(cuda): extend topk_softmax backend coverage - #891
Merged
Conversation
topk_softmax backend coverage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TopkSoftmaxprovider to Iluvatar, MetaX, and Moore.Motivation
InfiniCore still uses the deprecated
TopkSoftmaxInfinilmcompatibility operator on CUDA-compatible backends. Shared canonical provider coverage is required before that adapter can migrate toTopkSoftmax.Type of Change
feat- new feature / new operator / new platformfix- bug fixperf- performance improvement (no behavioral change)refactor- code restructuring without behavior changetest- adding or fixing tests onlydocs- documentation onlybuild/ci- build system or CI configurationchore- tooling, formatting, or other non-code changes!in the Conventional Commits prefix or aBREAKING CHANGE:footer)Platforms Affected
WITH_CPU)WITH_NVIDIA)WITH_ILUVATAR)WITH_METAX)WITH_CAMBRICON)WITH_MOORE)WITH_ASCEND)WITH_TORCH)Smoke Test Result
Validated on
ssh nvidiainaccelerator-dev/nvidia:latestas part of the canonical-provider integration stack:Test Results on Supported Platforms
Benchmark / Performance Impact
N/A. This PR relocates the existing kernel for reuse and adds dispatch providers.
Notes for Reviewers
The public schema is unchanged. This PR only shares the existing implementation and fills provider coverage.
TopkSoftmax(gating_output, bias, is_padding, renormalize, topk_weights, topk_indices, token_expert_indices)topk_softmax(topk_weights, topk_ids, token_expert_indices, gating_output, renormalize=False, e_score_correction_bias=None, is_padding=None)InfiniOps groups input tensors, attributes, and explicit outputs according to its C++ operator convention. Thus
biasmaps to vLLM'se_score_correction_bias,topk_indicesmaps totopk_ids, and the output tensors are trailing instead of leading. No overload is added.The NVIDIA result validates the relocated shared kernel and NVIDIA wrapper. Iluvatar, MetaX, and Moore platform CI remain required.