feat(nvidia): link vLLM topk_softmax provider - #906
Merged
Conversation
This was referenced Aug 7, 2026
voltjia
marked this pull request as ready for review
August 8, 2026 00:14
topk_softmax provider
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_moe_C::topk_softmaximplementation at NVIDIA slot 16.is_paddingat the linked boundary because the tested provider schema does not expose it.Motivation
Vendor vLLM 0.20.2 exposes a six-argument
topk_softmaxC10 operator. Registering it as a separate implementation proves the_moe_Cprovider path while preserving InfiniOps behavior for the parameter that this provider version lacks.N/A - no linked issue.
Type of Change
feat- new feature / new operator / new platformfix- bug fixperf- performance improvementrefactor- code restructuring without behavior changetest- adding or fixing tests onlydocs- documentation onlybuild/ci- build system or CI configurationchore- tooling, formatting, or other non-code changesPlatforms Affected
WITH_CPU)WITH_NVIDIA)WITH_ILUVATAR)WITH_METAX)WITH_CAMBRICON)WITH_MOORE)WITH_ASCEND)WITH_TORCH)Smoke Test Result
Test Results on Supported Platforms
Benchmark / Performance Impact
N/A - additive provider slot; no performance claim.
Notes for Reviewers
is_paddingis checked before tensor conversion and rejected withTORCH_CHECK, so Release and Debug behavior match.