fix: export active implementation query - #924
Merged
Merged
Conversation
This was referenced Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extern templatedeclarations and matching explicit instantiations forOperator<Op>::active_implementation_indices(Device::Type)in the installed operator call surface.0on CPU.Motivation
Downstream C++ consumers currently instantiate the query from installed public headers, where native implementation specializations are not visible, so a supported backend can incorrectly report no active implementations. Generating the query instantiation beside the existing operator call and default-implementation instantiations gives it the same specialization visibility as library dispatch.
No issue is linked.
Type of Change
feat- new feature / new operator / new platformfix- bug fixperf- performance improvement (no behavioral change)refactor- code restructuring without behavior changetest- adding or fixing tests onlydocs- documentation onlybuild/ci- build system or CI configurationchore- tooling, formatting, or other non-code changes!in the Conventional Commits prefix or aBREAKING CHANGE:footer)Platforms Affected
WITH_CPU)WITH_NVIDIA)WITH_ILUVATAR)WITH_METAX)WITH_CAMBRICON)WITH_MOORE)WITH_ASCEND)WITH_TORCH)Smoke Test Result
No platform kernel or Python binding changes are included. The focused shared-codegen tests and the installed-prefix C++ API smoke passed.
Test Results on Supported Platforms
Benchmark / Performance Impact
N/A. The change only exports an existing query through generated C++ template instantiations.
Notes for Reviewers
Please focus on whether the query declaration and definition are generated in the same operator-specific translation units as the existing default-implementation lookup. The CPU build used
WITH_TORCH=OFF,GENERATE_OPERATOR_CALL_INSTANTIATIONS=ON, andINFINI_OPS_OPS=add, then compiled and ran the smoke against the installed headers and libraries.