feat(ascend): add reshape_and_cache_flash provider - #973
Merged
Conversation
baominghelly
force-pushed
the
feat/ascend-reshape-cache
branch
from
September 3, 2026 06:37
c586ab3 to
c131103
Compare
baominghelly
marked this pull request as ready for review
September 3, 2026 07:07
reshape_and_cache_flash provider
voltjia
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reshape_and_cache_flashprovider insrc/native/ascend/ops/reshape_and_cache_flash/kernel.h.ScatterPaKvCachefor contiguous non-float32inputs and an ACLNNScatterNdUpdatefallback forfloat32or non-contiguous layouts.Motivation
Ascend model inference needs native KV-cache population for the existing
reshape_and_cache_flashinterface. Without this provider, paged-attention cache updates cannot use the InfiniOps slot-0 path on Ascend.Type of Change
feat— new feature / new operator / new platformfix— bug fixperf— performance improvement (no behavioral change)refactor— code restructuring without behavior changetest— adding or fixing tests onlydocs— documentation onlybuild/ci— build system or CI configurationchore— tooling, formatting, or other non-code changes!in the Conventional Commits prefix or aBREAKING CHANGE:footer)Platforms Affected
WITH_CPU)WITH_NVIDIA)WITH_ILUVATAR)WITH_METAX)WITH_CAMBRICON)WITH_MOORE)WITH_ASCEND)WITH_TORCH)Smoke Test Result
Test Results on Supported Platforms
tests/test_reshape_and_cache_flash.py: 24 passedFull `pytest` output (optional)
Benchmark / Performance Impact
N/A. This PR adds functional provider coverage and does not claim a performance improvement.
Notes for Reviewers
float32.float16,bfloat16, andfloat32, both NHD/HND layouts, and contiguous/non-contiguous cases in the complete operator test file.