Skip to content

Address remaining SSA review comments#196

Merged
voltjia merged 3 commits into
ssa-compiler-with-multibackendfrom
address-pr-164-review-comments
Jul 16, 2026
Merged

Address remaining SSA review comments#196
voltjia merged 3 commits into
ssa-compiler-with-multibackendfrom
address-pr-164-review-comments

Conversation

@voltjia

@voltjia voltjia commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Keep the root package API conservative by exposing the SSA jit entrypoint without adding root-level aot or lower exports.
  • Normalize auto-tuning naming across tests and user-facing errors while preserving the AutoTuner type.
  • Align CompileRequest and its construction sites with the established arrangement, application, tensors order.
  • Add the requested registry spacing and keep the compiler entrypoint coverage focused on supported behavior.

Scope

This follows up the four unresolved review threads on #164. It does not address the Triton AOT multi-device/context issue, which is covered by #195.

Validation

  • Built and installed the editable package in accelerator-dev/nvidia:latest with pip install --no-deps --force-reinstall -e ..
  • ruff check (Ruff 0.15.21)
  • ruff format --check (Ruff 0.15.21)
  • python scripts/check_contributing_style.py
  • Current affected tests after the requested test cleanup: 96 passed
  • Full NVIDIA single-device suite from the production-code commit is shown below. The subsequent commits only adjust test coverage and import ordering. The multi-device case is skipped for Fix Triton AOT multi-context launches #195; the TileLang reload parameter is deselected because the NVIDIA image does not include the optional TileLang dependency.

pytest output:

$ CUDA_VISIBLE_DEVICES=0 PYTHONPATH=src python -m pytest \
    --deselect='tests/test_built_artifact_reload.py::test_aot_built_artifact_can_be_reloaded[tilelang-cuda]'

collected 338 items / 1 deselected / 337 selected

========== 336 passed, 1 skipped, 1 deselected in 1851.00s (0:30:50) ==========

@voltjia
voltjia marked this pull request as ready for review July 15, 2026 14:30
@voltjia
voltjia merged commit db3667c into ssa-compiler-with-multibackend Jul 16, 2026
11 checks passed
@voltjia
voltjia deleted the address-pr-164-review-comments branch July 16, 2026 09:10
voltjia added a commit that referenced this pull request Jul 16, 2026
* Add SSA compiler pipeline and unified backends

* refine ssa multibackend PR boundaries and pass registration

* move backend ssa pass registration into backend modules

* Add backend SSA pass contracts and registry validation

* revert test_aot_auto_tuning.py

* fix ruff

* style: satisfy contributing style checks after rebase

* Refactor SSA compiler naming (#169)

* Refactor IR dataclass constructors (#172)

* unify SSA compilation and executable multi-backend support

* Fix ruff error, refine SSA compiler structure and address review feedback

* Refactor SSA backend pipeline and restore Triton runtime autotining

* Removing TVM backend and refine Triton, CUDA, TileLang backends

* Fix zero-like GPU launches, architecture-aware caching, and JIT API

* Fix Triton AOT multi-context launches (#195)

* Add Triton AOT multi-context design

* Fix Triton AOT multi-context launches

* Cover fresh Triton AOT context guard

* Remove development process documents

* Address remaining SSA review comments (#196)

* Address remaining SSA review comments

* Sort test imports for Ruff

* Remove redundant entrypoint assertions

---------

Co-authored-by: Jiacheng Huang <45955067+voltjia@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant