-
Notifications
You must be signed in to change notification settings - Fork 0
feat: Two factor auth confirmation #509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
2721ae3
feat(TwoFactorAuth): Add initial UI
LouisCAD 029213e
feat(TwoFactorAuth): Add RemoteChallenge model for JSON
LouisCAD 400da53
feat(TwoFactorAuth): Add abstraction for TwoFactorAuth challenges
LouisCAD 29ef990
feat(TwoFactorAuth): Update TwoFactorAuth UI style
LouisCAD 254a6aa
feat(TwoFactorAuth): Update TwoFactorAuth UI
LouisCAD d6f7656
feat(TwoFactorAuth): Implement TwoFactorAuth
LouisCAD 2e31cf3
chore(TwoFactorAuth): Add TODOs
LouisCAD c113583
feat(TwoFactorAuth): Add AbstractTwoFactorAuthViewModel and update re…
LouisCAD a9151a9
chore(TwoFactorAuth): Update SecurityTheme for bottom sheet
LouisCAD 048cb46
chore(TwoFactorAuth): Improve modal bottom sheet showing logic
LouisCAD ac25997
feat(TwoFactorAuth): Add addComposeOverlay and hostComposeOverlay hel…
LouisCAD 2dabf52
refactor(TwoFactorAuth): Simplify implementation of
LouisCAD 9fac068
chore(TwoFactorAuth): Add TwoFactorAuthTestImpl to test the UI
LouisCAD 7b5e8f9
chore(TwoFactorAuth): Update RemoteChallenge backend model
LouisCAD f3161f0
chore(TwoFactorAuth): Switch back to real TwoFactorAuth impl (from te…
LouisCAD 251fc0c
chore: Replace no longer needed UuidForKotlin2 with stdlib usage
LouisCAD aa24762
chore(TwoFactorAuth): Add capabilities and version info in DeviceInfo
LouisCAD 861cbff
fix: Add correct user agent when sending device info
LouisCAD f8f4698
chore: Add Content-Type validation check
LouisCAD bd5c078
chore: Update JSON config to match DefaultJson from ktor
LouisCAD bbe49ad
chore(TwoFactorAuth): Add translations
LouisCAD 1eb52a8
chore: Don't send versionCode to the backend
LouisCAD d651796
chore(TwoFactorAuth): Add device type icon
LouisCAD File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39 changes: 39 additions & 0 deletions
39
Compose/Basics/src/main/kotlin/com/infomaniak/core/compose/basics/WithLatestNotNull.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| /* | ||
| * Infomaniak Core - Android | ||
| * Copyright (C) 2025 Infomaniak Network SA | ||
| * | ||
| * This program is free software: you can redistribute it and/or modify | ||
| * it under the terms of the GNU General Public License as published by | ||
| * the Free Software Foundation, either version 3 of the License, or | ||
| * (at your option) any later version. | ||
| * | ||
| * This program is distributed in the hope that it will be useful, | ||
| * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| * GNU General Public License for more details. | ||
| * | ||
| * You should have received a copy of the GNU General Public License | ||
| * along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
| */ | ||
| package com.infomaniak.core.compose.basics | ||
|
|
||
| import androidx.compose.runtime.Composable | ||
| import androidx.compose.runtime.getValue | ||
| import androidx.compose.runtime.mutableStateOf | ||
| import androidx.compose.runtime.remember | ||
|
|
||
| /** | ||
| * Gives access to the latest non null value of the receiver. | ||
| * | ||
| * Helpful to keep showing populated UI during exit animations. | ||
| */ | ||
| @Composable | ||
| fun <T> T?.WithLatestNotNull(content: @Composable (T) -> Unit) { | ||
| // The implementation is similar to rememberUpdatedState. | ||
| val value by remember { mutableStateOf(this) }.also { | ||
| if (this != null) it.value = this | ||
| } | ||
| value?.let { | ||
| content(it) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
59 changes: 0 additions & 59 deletions
59
.../main/kotlin/com/infomaniak/core/crossapplogin/back/internal/extensions/UuidForKotlin2.kt
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.