feat: Two factor auth confirmation #509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LouisCAD
force-pushed
the
two-factor-auth
branch
4 times, most recently
from
9e7bc55 to
1b60d71
Compare
LouisCAD
force-pushed
the
two-factor-auth
branch
3 times, most recently
from
d42749d to
0894cf2
Compare
1 task
LouisCAD
force-pushed
the
two-factor-auth
branch
2 times, most recently
from
c531904 to
e26b630
Compare
FabianDevel
requested changes
Oct 13, 2025
Contributor
FabianDevel
left a comment
FabianDevel
left a comment
There was a problem hiding this comment.
See if we can sort the challenges by their expiration or creation time to open the oldest one first
Compose/Basics/src/main/kotlin/com/infomaniak/core/compose/basics/Dimens.kt
Show resolved
Hide resolved
...com/infomaniak/core/crossapplogin/back/internal/deviceinfo/AbstractDeviceInfoUpdateWorker.kt
Show resolved
Hide resolved
...com/infomaniak/core/crossapplogin/back/internal/deviceinfo/AbstractDeviceInfoUpdateWorker.kt
Show resolved
Hide resolved
...kotlin/com/infomaniak/core/crossapplogin/back/internal/deviceinfo/DeviceInfoUpdateManager.kt
Show resolved
Hide resolved
...com/infomaniak/core/crossapplogin/back/internal/deviceinfo/AbstractDeviceInfoUpdateWorker.kt
Show resolved
Hide resolved
...com/infomaniak/core/crossapplogin/back/internal/deviceinfo/AbstractDeviceInfoUpdateWorker.kt
Show resolved
Hide resolved
...kotlin/com/infomaniak/core/crossapplogin/back/internal/deviceinfo/DeviceInfoUpdateManager.kt
Show resolved
Hide resolved
...kotlin/com/infomaniak/core/crossapplogin/back/internal/deviceinfo/DeviceInfoUpdateManager.kt
Show resolved
Hide resolved
the challengeToResolve property
LouisCAD
force-pushed
the
two-factor-auth
branch
from
e26b630 to
d651796
Compare
|
FabianDevel
requested changes
Oct 14, 2025
FabianDevel
requested changes
Oct 16, 2025
...com/infomaniak/core/crossapplogin/back/internal/deviceinfo/AbstractDeviceInfoUpdateWorker.kt
Show resolved
Hide resolved
FabianDevel
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't merge just yet since we're waiting for backend endpoints.
Opened this to allow for early review.
Known issues:
These will be handled in a subsequent PR (and yet another, later one for push notifications).
Review recommendation:
Look at the file tree first ("Files changed", then the diff tree overview on the left), that will help you target the backend of the frontend code, and other stuff.