chore: Clean User class#764
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR simplifies the User/preferences model by removing unused preference fields (language/country/timezone and most security fields) and updates persistence + supporting code accordingly.
Changes:
- Slim down
PreferencesandSecuritymodels (and update dummy/test user builders accordingly). - Add a Room auto-migration spec for DB v6 to drop removed
Usertable columns; update the exported Room schema. - Simplify
ApiRepositoryCore.getUserProfile()by removing thewith*expansion flags and always calling the base profile route.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Ui/Compose/Preview/.../UserListPreviewParameterProvider.kt | Update preview dummy user builder to match new Preferences signature. |
| Auth/src/test/.../BaseAccountUtilsTest.kt | Update test helper user builder to match new Preferences signature. |
| Auth/src/main/.../room/UserMigration.kt | Add UserV6Migration deleting removed preference/security columns from User. |
| Auth/src/main/.../room/UserDatabase.kt | Wire the 5→6 auto-migration to UserV6Migration. |
| Auth/src/main/.../preferences/security/Security.kt | Remove unused security fields from the model. |
| Auth/src/main/.../preferences/Preferences.kt | Remove language/country/timezone from preferences; keep security + organization. |
| Auth/src/main/.../api/ApiRepositoryCore.kt | Remove withEmails/withPhones/withSecurity params and corresponding URL query building. |
| Auth/schemas/.../6.json | Update exported Room schema to reflect removed columns and new identity hash. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tevincent
force-pushed
the
clean-user-object
branch
from
308e0bb to
a1f5d96
Compare
LouisCAD
approved these changes
May 12, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.