chore: Remove lastLoginAt#765
Merged
Merged
Conversation
LouisCAD
approved these changes
May 12, 2026
|
There was a problem hiding this comment.
Pull request overview
This PR removes the lastLoginAt field from OrganizationPreference in both the Auth and Legacy user preference models, and updates dependent preview/test fixtures and Room schema/migration artifacts accordingly.
Changes:
- Removed
lastLoginAtfromOrganizationPreference(Auth + Legacy). - Updated call sites (Compose preview parameter + Auth unit test) to match the new constructor signature.
- Updated Auth Room migration annotations and the exported Room schema snapshot.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Ui/Compose/Preview/.../UserListPreviewParameterProvider.kt | Updates preview dummy user generation for the new OrganizationPreference constructor. |
| Legacy/.../OrganizationPreference.kt | Removes lastLoginAt from the Legacy preferences model. |
| Auth/src/test/.../BaseAccountUtilsTest.kt | Updates test fixture user creation for the new OrganizationPreference constructor. |
| Auth/src/main/.../UserMigration.kt | Adds a Room @DeleteColumn for the removed embedded column. |
| Auth/src/main/.../OrganizationPreference.kt | Removes lastLoginAt from the Auth preferences model. |
| Auth/schemas/.../6.json | Updates exported Room schema snapshot to remove the column and reflect new identity hash. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.