fix: cap affinity bitmap and canvas pixel count - #30
Merged
IAmJSD merged 2 commits intoAug 25, 2026
Conversation
check_pixel_count was only tested directly, so dropping a call site in build or decode_bitmap would leave the suite green. Parse a real probe fixture, inflate its declared canvas and bitmap sizes past the cap, and watch both paths refuse. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
IAmJSD
approved these changes
Aug 25, 2026
IAmJSD
left a comment
IAmJSD
left a comment
Member
There was a problem hiding this comment.
The cap is enforced on both the canvas and bitmap paths, and the new fixture-based test exercises it through the real import path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #29
add a shared
check_pixel_countand call it from both the canvas and the bitmap path. the ceiling is 2^28 pixels, a 16384x16384 image, which bounds the rgba buffer at 1 GiB.capping area rather than either side keeps legitimate shapes working: a 1048576x16 strip still imports.
the multiply saturates, so an overflowing pair cannot wrap into a small number and slip through.
before
after