Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR augments the archive output with author and tag metadata and refreshes several dependencies.
- Added
AuthorandTagsfields toArticleInfoand updated theBuildfunction to set them. - Swapped out
facebookgo/symwalkforedwardrf/symwalkand bumped versions of fsnotify, markdown, feeds, websocket, urfave/cli, and other modules.
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| serve.go | Updated import path for symwalk from facebookgo to edwardrf |
| main.go | Updated import path for symwalk from facebookgo to edwardrf |
| build.go | Added Author and Tags to ArticleInfo and populate in Build |
| api.go | Updated import path for symwalk from facebookgo to edwardrf |
| go.mod | Replaced sources and bumped versions of several dependencies |
Comments suppressed due to low confidence (6)
build.go:30
- Add a doc comment for the
Authorfield inArticleInfoto explain its purpose and expected structure.
Author AuthorConfig
build.go:31
- Add a doc comment for the
Tagsfield inArticleInfoto clarify the format and usage of tags.
Tags []string
build.go:167
- Add unit tests to verify that
Build()correctly propagates theAuthorfield into the archive output.
Author: article.Author,
build.go:168
- Add unit tests to verify that
Build()correctly propagates theTagsfield into the archive output.
Tags: article.Tags,
go.mod:15
- [nitpick] Review the changelog for
urfave/cli/v2to ensure this bump doesn't introduce breaking changes in CLI flags or behavior.
github.com/urfave/cli/v2 v2.27.7
serve.go:9
- [nitpick] Ensure there are no remaining references to
facebookgo/symwalkin the codebase to prevent inconsistent imports.
"github.com/edwardrf/symwalk"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds author and tag information to
.Archive.Articles, as this data is required by some themes for their archive pages.It also replaces several unmaintained dependencies.