Skip to content

Comments

Make Ping return an Attempt#15

Merged
Baptouuuu merged 1 commit intodevelopfrom
attempt
May 8, 2025
Merged

Make Ping return an Attempt#15
Baptouuuu merged 1 commit intodevelopfrom
attempt

Conversation

@Baptouuuu
Copy link
Member

This is a more accurate type and allows user debug what went wrong.

@Baptouuuu Baptouuuu self-assigned this May 8, 2025
@Baptouuuu Baptouuuu added the enhancement New feature or request label May 8, 2025
@codecov
Copy link

codecov bot commented May 8, 2025

Codecov Report

Attention: Patch coverage is 98.14815% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.22%. Comparing base (1cd7030) to head (3e4a4ae).

Files with missing lines Patch % Lines
src/Ping/ProcessOutput.php 96.29% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop      #15      +/-   ##
=============================================
+ Coverage      97.06%   97.22%   +0.15%     
  Complexity        56       56              
=============================================
  Files             13       13              
  Lines            307      324      +17     
=============================================
+ Hits             298      315      +17     
  Misses             9        9              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Baptouuuu Baptouuuu merged commit 3fea28e into develop May 8, 2025
64 checks passed
@Baptouuuu Baptouuuu deleted the attempt branch May 8, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant