Fix Sequence->snap()->toSet() being lazy #55
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In #54 the
Sequence->snap()->toSet()was thought to be safe of using a lazySetas the underlying value was correctly memoized.The problem is that any transformation applied on it is now lazy. Meaning that if a transformation implies creating an object then these objects are re-created each time.
This is problematic for
formal/ormas it relies on object identity to know what to persist.Solution
->snap()is applied on the lazySetto make sure everything is kept in memory.