Skip to content

Conversation

@Baptouuuu
Copy link
Member

Problem

In #54 the Sequence->snap()->toSet() was thought to be safe of using a lazy Set as the underlying value was correctly memoized.

The problem is that any transformation applied on it is now lazy. Meaning that if a transformation implies creating an object then these objects are re-created each time.

This is problematic for formal/orm as it relies on object identity to know what to persist.

Solution

->snap() is applied on the lazy Set to make sure everything is kept in memory.

@Baptouuuu Baptouuuu added the bug Something isn't working label May 2, 2025
@Baptouuuu Baptouuuu self-assigned this May 2, 2025
@codecov
Copy link

codecov bot commented May 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.15%. Comparing base (fe00ac8) to head (150b761).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop      #55      +/-   ##
=============================================
- Coverage      97.23%   97.15%   -0.09%     
  Complexity      1062     1062              
=============================================
  Files             75       75              
  Lines           5252     5268      +16     
=============================================
+ Hits            5107     5118      +11     
- Misses           145      150       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Baptouuuu Baptouuuu merged commit df6b056 into develop May 2, 2025
32 of 33 checks passed
@Baptouuuu Baptouuuu deleted the fix-snap-toSet branch May 2, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants