Fix Set::equals() loading its data when not necessary
#57
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Closes #56
Unlike mentioned in the issue this is not problematic for
formal/ormas it compares the objects identity before calling theequalsmethod.But this problem could still exist elsewhere.
Solution
Add a check at the start of the method to make an early return if the other
Setis itself.Note
The same problem applied to
Sequence::equals()and has been fixed the same way.