Skip to content

Conversation

@Baptouuuu
Copy link
Member

It's either Attempt<Process> when executing a command or Attempt<SideEffect> for everything else.

This is motivated to allow more errors being returned and not directly the one that can happen related to the process. For example a process may not start.

@Baptouuuu Baptouuuu added the enhancement New feature or request label Apr 21, 2025
@Baptouuuu Baptouuuu self-assigned this Apr 21, 2025
@codecov
Copy link

codecov bot commented Apr 21, 2025

Codecov Report

Attention: Patch coverage is 99.03846% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.22%. Comparing base (8df354d) to head (7b60078).

Files with missing lines Patch % Lines
tests/Server/Processes/UnixTest.php 92.30% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop      #18      +/-   ##
=============================================
+ Coverage      97.08%   97.22%   +0.13%     
  Complexity       312      312              
=============================================
  Files             58       58              
  Lines           2061     2089      +28     
=============================================
+ Hits            2001     2031      +30     
+ Misses            60       58       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Baptouuuu Baptouuuu changed the title make all methods that may fail return an Attempt Make all methods that may fail return an Attempt Apr 21, 2025
@Baptouuuu Baptouuuu merged commit 60f2cda into develop Apr 21, 2025
64 checks passed
@Baptouuuu Baptouuuu deleted the attempt branch April 21, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants