Have updateFormat return MediaFormat#147
Merged
Inrixia merged 3 commits intoInrixia:masterfrom Mar 4, 2026
Merged
Conversation
Owner
|
Could you please add a commit to bump client patch version. As soon as that's done I'll merge this 💜 |
Contributor
Author
|
@Inrixia , done 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
updateFormatnow returnsMediaFormat | undefinedinstead ofvoid, allowing callers to directly access the format data without needing to use thewithFormatcallback patternMotivation
Currently, the only way to access format data (
bitDepth,sampleRate, etc.) after callingupdateFormatis through thewithFormatlistener/callback pattern. This forces callers to wrap the call in aPromisewithwithFormatjust to get the result - e.g. in Inrixia/luna-plugins#222 where we need to log format info.With this change, callers can simply do:
Details