Use new allowBuilds key to fix pnpm postinstall scripts#236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems like the build failure originates from pnpm v11 changing some keys and tightening security (and it's automatically pulled since the pnpm version in the action is set to latest).
In v11, the correct key for allowing build scripts is now called
allowBuilds: https://pnpm.io/settings#allowbuildsIf you're very suspicious about build scripts you could seemingly also allow the scripts only for pinned versions of those packages, but that's up to you how worried you are about supply chain stuff :)