feat(volume): insta compute volume --size attaches when no volume exists - #84
Merged
Merged
Conversation
…xists The backend (insta-platform #185) lifted attach-at-create-only: PUT .../volume on a volumeless compute service now attaches. CLI side: the volumeless read points at `insta compute volume <name> --size <gi>` instead of "recreate the service", and the PUT result words a first attach (mounts at /data on the next deploy) differently from a grow, keyed on the response's `attached` flag (absent on older backends = grow wording, unchanged behavior). Help text for `services add --volume` and `compute volume` updated to match. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LPyX5GsxHvWqLpPYiUCfb5
tonychang04
marked this pull request as ready for review
August 7, 2026 23:48
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
CLI half of attach-after-create for compute volumes (backend: InsForge/insta-platform#185, flagged by Tony 2026-08-07 — recreating a service to give it a disk is a gap).
insta compute volume <name>read now points atinsta compute volume <name> --size <gi>(this command) instead of "attach is create-time only: recreate viaservices add".volume 3Gi attached — mounts at /data on the next deploy— from a grow (volume grown to 5Gi at /data), keyed on the backend's newattachedresponse flag. Older backends omit the flag → grow wording, behavior unchanged.services add --volumeandcompute volumeupdated; no client-side gating added — the backend's 403/400 messages still speak verbatim.New
volumeWriteLineis pure and exported for tests, mirroringvolumeLines.Tests
232/232 green. New: volumeWriteLine attach vs grow (flag false and absent), volumeless read hint points at the attach verb.
🤖 Generated with Claude Code
https://claude.ai/code/session_01LPyX5GsxHvWqLpPYiUCfb5
Summary by cubic
Allow attaching a compute volume after creation via
insta compute volume <name> --size, removing the need to recreate services. Improves CLI messages and keeps behavior compatible with older backends.insta compute volume --sizeattaches when no volume exists; grows otherwise.insta compute volume <name> --size <gi>instead of recreate.attachedflag (absent = grow wording).services add --volumeandcompute volume.volumeWriteLineand added tests.Written for commit d311ef6. Summary will update on new commits.