Skip to content

Add etas to results table - #46

Merged
mccarthy-m-g merged 6 commits into
mainfrom
add-etas
Jun 5, 2026
Merged

Add etas to results table#46
mccarthy-m-g merged 6 commits into
mainfrom
add-etas

Conversation

@mccarthy-m-g

Copy link
Copy Markdown
Collaborator

This PR adds etas to the results table. I opted to add two types of etas:

  • eta<nn> etas, which are the iterative empirical Bayes estimates that pair with iter_ipred.
  • map_eta<nn> etas, which are the full-data MAP empirical Bayes estimates that pair with map_ipred. These are the equivalent of the etas reported in a NONMEM output table, and are what you'd use for an empirical eta-distribution plot.

I also updated the documentation for run_eval() to document its outputs more thoroughly, particularly with a @details section describing the results table.

@dominic-irx dominic-irx left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works great if everything works smoothly.

can you write a test to make sure that if all fits fail that the function returns something useful (warning, maybe)? also looks like line 97 (par_dummy) won't have etas.

@mccarthy-m-g

Copy link
Copy Markdown
Collaborator Author

works great if everything works smoothly.

can you write a test to make sure that if all fits fail that the function returns something useful (warning, maybe)? also looks like line 97 (par_dummy) won't have etas.

Done! c366ba5 addresses the above.

We actually had an appropriate warning already in calculate_stats(), so I refactored that to occur in run_eval() instead: efd88e4. The warning can still be triggered in calculate_stats() when it's run outside run_eval() though

@mccarthy-m-g
mccarthy-m-g requested a review from dominic-irx June 5, 2026 20:42
@mccarthy-m-g
mccarthy-m-g merged commit 19482ca into main Jun 5, 2026
2 checks passed
@mccarthy-m-g
mccarthy-m-g deleted the add-etas branch June 5, 2026 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants