BUG: TubeSpatialObject normals not unit vectors - #1972
Merged
aylward merged 2 commits intoSep 1, 2020
Conversation
TubeSpatialObject::ComputeTangent(s)AndNormals() would result in certain normals not being unit vectors. This fixes and tests for those errors. COMP: Fixes a spelling mistake in ComputeTangentAndNormals by making Tangents plural, as it should be. This function is primarily used by internal methods so chances of breaking backward compartibility are slim.
dzenanz
reviewed
Aug 31, 2020
dzenanz
left a comment
dzenanz
left a comment
Member
There was a problem hiding this comment.
Looks good on a glance. I guess you forgot to rename one invocation place:
Examples/SpatialObjects/TubeSpatialObject.cxx:138:9: error: no member named 'ComputeTangentAndNormals' in 'itk::TubeSpatialObject<3, itk::TubeSpatialObjectPoint<3> >'; did you mean 'ComputeTangentsAndNormals'?
Examples/SpatialObjects/TubeSpatialObject.cxx:138:9: error: 'using ObjectType = class itk::TubeSpatialObject<3u> {aka class itk::TubeSpatialObject<3u>}' has no member named 'ComputeTangentAndNormals'; did you mean 'ComputeTangentsAndNormals'?
Missed one call that needed to be updated to use the corrected spelling.
Member
Author
|
@dzenanz - thanks for catching that! Fixed! If approved, I would squash and merge. |
dzenanz
approved these changes
Sep 1, 2020
Member
|
Yes, please squash. |
hjmjohnson
pushed a commit
to hjmjohnson/ITK
that referenced
this pull request
May 6, 2026
…rtium#1972) * BUG: TubeSpatialObject normals not unit vectors TubeSpatialObject::ComputeTangent(s)AndNormals() would result in certain normals not being unit vectors. This fixes and tests for those errors. COMP: Fixes a spelling mistake in ComputeTangentAndNormals by making Tangents plural, as it should be. This function is primarily used by internal methods so chances of breaking backward compartibility are slim.
hjmjohnson
pushed a commit
to hjmjohnson/ITK
that referenced
this pull request
May 12, 2026
…rtium#1972) * BUG: TubeSpatialObject normals not unit vectors TubeSpatialObject::ComputeTangent(s)AndNormals() would result in certain normals not being unit vectors. This fixes and tests for those errors. COMP: Fixes a spelling mistake in ComputeTangentAndNormals by making Tangents plural, as it should be. This function is primarily used by internal methods so chances of breaking backward compartibility are slim.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TubeSpatialObject::ComputeTangent(s)AndNormals() would result in
certain normals not being unit vectors. This fixes and tests for
those errors.
COMP: Fixes a spelling mistake in ComputeTangentAndNormals by
making Tangents plural, as it should be. This function is primarily
used by internal methods so chances of breaking backward compartibility
are slim.
PR Checklist
Refer to the ITK Software Guide for
further development details if necessary.