Skip to content

BUG: Do no install any Eigen3 targets if ITK_USE_SYSTEM_EIGEN=ON#580

Merged
dzenanz merged 1 commit into
InsightSoftwareConsortium:masterfrom
phcerdan:fix_eigen3_install_system
Mar 11, 2019
Merged

BUG: Do no install any Eigen3 targets if ITK_USE_SYSTEM_EIGEN=ON#580
dzenanz merged 1 commit into
InsightSoftwareConsortium:masterfrom
phcerdan:fix_eigen3_install_system

Conversation

@phcerdan

@phcerdan phcerdan commented Mar 9, 2019

Copy link
Copy Markdown
Contributor

Also added documentation about the logic having two Eigen3 targets,
and a minimal CMake example for usage in external modules.

Raised in: microsoft/vcpkg#5115 (comment)

@thewtex thewtex left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates and clarification @phcerdan !

A few grammatical issues inline.

Comment thread Modules/ThirdParty/Eigen3/CMakeLists.txt Outdated
Comment thread Modules/ThirdParty/Eigen3/CMakeLists.txt Outdated
Comment thread Modules/ThirdParty/Eigen3/CMakeLists.txt Outdated
Also added documentation about the logic having two Eigen3 targets,
and a minimal CMake example for usage in external modules.

Raised in: microsoft/vcpkg#5115 (comment)
@phcerdan phcerdan force-pushed the fix_eigen3_install_system branch from e1b5d16 to 3ba0d94 Compare March 11, 2019 03:48
@dzenanz dzenanz dismissed thewtex’s stale review March 11, 2019 16:56

Out of date

@dzenanz dzenanz merged commit 14b74af into InsightSoftwareConsortium:master Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants