BUG: Update Eigen3 to fix INSTALL_DIR problems#588
Merged
phcerdan merged 2 commits intoMar 14, 2019
Conversation
Code extracted from:
https://gitlab.kitware.com/phcerdan/eigen.git
at commit 8a3c2d91e9d8d70ba187618265869b51610a1f00 (for/itk).
Change-Id: I90eb721c21edeef84510c76d3a100029dbaaacda
* upstream-Eigen3: Eigen3 2019-03-14 (8a3c2d91)
dzenanz
approved these changes
Mar 14, 2019
hjmjohnson
pushed a commit
to hjmjohnson/ITK
that referenced
this pull request
May 6, 2026
…_eigen3 BUG: Update Eigen3 to fix INSTALL_DIR problems
hjmjohnson
pushed a commit
to hjmjohnson/ITK
that referenced
this pull request
May 12, 2026
…_eigen3 BUG: Update Eigen3 to fix INSTALL_DIR problems
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes patch:
BUG: ITK: CMake files are now installed in ITK_INSTALL_PACKAGE_DIR/Modules
Instead of hard coded path including the version.
When using
ITK_INSTALL_PACKAGE_DIR=lib/cmake/ITKBefore (wrong):
]$ find ITK-prefix | grep Eigen3 ITK-prefix/lib/cmake/ITK-5.0/Modules/Eigen3Config.cmake ITK-prefix/lib/cmake/ITK-5.0/Modules/Eigen3ConfigVersion.cmake ITK-prefix/lib/cmake/ITK-5.0/Modules/ITKInternalEigen3Config.cmake ITK-prefix/lib/cmake/ITK-5.0/Modules/ITKInternalEigen3Targets.cmake ITK-prefix/lib/cmake/ITK-5.0/Modules/ITKInternalEigen3ConfigVersion.cmake ITK-prefix/lib/cmake/ITK-5.0/Modules/Eigen3Targets.cmake ITK-prefix/lib/cmake/ITK/Modules/ITKEigen3.cmakeAfter this fix:
Fix #584