ENH: Add empty .pre-commit-config.yaml for release-5.4 - #6837
Conversation
dzenanz
left a comment
There was a problem hiding this comment.
Looks good to me. Someone else should preferably review.
|
hjmjohnson
left a comment
There was a problem hiding this comment.
Love it! This is 95% of what I think should be done.
The last 5% is completely optional, and should not hold this up. I would want to backport the items that are "free" to backport.
|
Love it! This is 95% of what I think should be done. The last 5% is completely optional, and should not hold this up. I would want to backport the items that are "free" to backport. I dropped Full hook-by-hook result on release-5.4
Reproduce with: git worktree add /tmp/r54 upstream/release-5.4
# copy the pre-commit-hooks repo block from main's .pre-commit-config.yaml
pre-commit run --all-filesThe 4 failures, in full
Why the whitespace hooks in particular are worth having hereThis PR's own justification is that commits get backported from Worth noting the 4 failures are all genuine defects of the kind these hooks exist to catch — a Tiny nit, take it or leave it: Either way — none of this should block merging as-is. The empty config solves the stated problem, and the hook enablement is a clean follow-up whenever it suits. |
Prevents pre-commit errors when backporting commits from branches where pre-commit hooks are configured.
90e8157 to
f42c5d9
Compare
695bb17
into
InsightSoftwareConsortium:release-5.4
|
@hjmjohnson Your suggested followup would be nice. |
Prevents pre-commit errors when backporting commits from branches where pre-commit hooks are configured.
PR Checklist
Refer to the ITK Software Guide for
further development details if necessary.